Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add editor-config and apply rules to generated files #2995

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add editor-config and apply rules to generated files #2995

wants to merge 1 commit into from
+405 −41

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented Mar 13, 2025 •
edited
Loading

Proposed change

feat: add editor-config and apply rules to generated files

Related issues

- No issue associated -

@kpanot kpanot requested a review from a team as a code owner March 13, 2025 12:01
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit bb096eb.

Command Status Duration Result
nx run-many --target=test-int ✅ Succeeded 38m 22s View ↗
nx run-many --target=test-e2e ✅ Succeeded 8m 58s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded 1s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 32s View ↗
nx run-many --target=prepare-publish --exclude-... ✅ Succeeded 1m 25s View ↗
nx run-many --target=build,build-swagger ✅ Succeeded 17m 20s View ↗
nx affected --target=test --collectCoverage ✅ Succeeded 11m 2s View ↗
nx affected --target=lint --configuration ci ✅ Succeeded 14m 44s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-15 04:40:26 UTC

@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (3e4a8f3) to head (bb096eb).
Report is 69 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../src/rule-factories/editor-config/editor-config.ts 96.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kpanot kpanot force-pushed the feature/editor-config branch 2 times, most recently from 5288de6 to aab7f0e Compare March 13, 2025 14:50
@kpanot kpanot force-pushed the feature/editor-config branch 10 times, most recently from 73a6c50 to 25fdfea Compare March 14, 2025 14:45
@kpanot kpanot force-pushed the feature/editor-config branch from 25fdfea to bb096eb Compare March 15, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-crouzet matthieu-crouzet matthieu-crouzet left review comments

@fpaul-1A fpaul-1A fpaul-1A left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/design project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/schematics project:@o3r/style-dictionary project:@o3r/telemetry project:@o3r/testing project:@o3r/workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing final newline in generated files
3 participants
@kpanot @matthieu-crouzet @fpaul-1A