WFS post requests #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstokkink
force-pushed
the
pieter/wfs-post-requests
branch
4 times, most recently
from
89d34f4 to
d5779d1
Compare
… sense in a POST request context.
pstokkink
force-pushed
the
pieter/wfs-post-requests
branch
from
0cdd40c to
f24b2c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dit zorgt voor ondersteuning van POST requests voor alle methods die we ook via GET ondersteunen.
Daarnaast is een test helper gebouwd die het parametrizen van tests met verschillende urls/request methods eenvoudiger maakt. De bulk daarvan staat in
tests/requests.py, een fixture en een helper om de test-ids goed te krijgen staan inconftest.py, misschien moeten we de boel consolideren. Het neigt enigszins naar library code, maar is nu nog flink gecoupled met deze usecase, wellicht kunnen we het op een bepaald moment lostrekken en een manier inbouwen om het te configureren, mocht het handig zijn om in andere repos deze code ook te gebruiken.Voor voorbeelden van hoe het gebruikt wordt zie de overige testfiles.