Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix scopes property for dso #579

Merged
merged 12 commits into from
Feb 19, 2025
Merged

Bugfix scopes property for dso #579

merged 12 commits into from
Feb 19, 2025

Conversation

pstokkink
Copy link
Contributor

No description provided.

@pstokkink
Ensure we are not leaking errors on the scopes property
75e5104 
- wrap loader in own @Property with centralized error handling
- catch errors inside scopes @Property
@pstokkink
patch 6.5.1
1642c50
@pstokkink
fall back on self.auth
2284dfb
@pstokkink pstokkink force-pushed the pieter/bugfix-scopes-property-for-dso branch from aa3077f to 2284dfb Compare February 17, 2025 16:06
@pstokkink pstokkink force-pushed the pieter/bugfix-scopes-property-for-dso branch from 81d3530 to 0535a0d Compare February 17, 2025 16:10
vdboor
vdboor requested changes Feb 18, 2025
View reviewed changes
@vdboor
Copy link
Contributor

vdboor commented Feb 18, 2025

  • Bij tabellen nog de velden doorlopen voor refs naar scopes.
  • inline_refs=True i.p.v. de losse flags?

@pstokkink
Copy link
Contributor Author

pstokkink commented Feb 18, 2025 •
edited
Loading

inline_refs gaat niet helemaal werken zoals bedoeld, want voor de validatie vanuit de cli willen we alleen de tabellen inlinen, niet de publishers/scopes (want dat zou het schema invalid maken). Voor nu zo gelaten.

vdboor
vdboor reviewed Feb 19, 2025
View reviewed changes
@pstokkink pstokkink merged commit 062c86e into master Feb 19, 2025
9 checks passed
@pstokkink pstokkink deleted the pieter/bugfix-scopes-property-for-dso branch February 19, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdboor vdboor vdboor approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstokkink @vdboor