Refactor scopes methods #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstokkink
force-pushed
the
pieter/refactor-scopes-methods
branch
from
4cb3c67 to
73475d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dit was nog overgebleven van de byo-accesspackage feature.
Ook een bug gevonden 😱 (die we impliciet verholpen door terug te vallen op auth velden).
NB❗: De assumptie hierachter is dat voor alle bestaande auth strings die in gebruik zijn een scope object binnen amsterdam-schema bestaat.
NB2❗: Als we DSO-API met deze versie willen laten werken, moeten we ook daar de
_find_scope_by_idmethod monkeypatchen in de tests. Heb dat lokaal al werkend.