Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ordering on the areas public and private endpoint #1439

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

vanbuiten
Copy link
Member

Description

Added ordering on the areas public and private endpoint + by default order on _type,name + added tests

Checklist

  • Keep the PR, and the amount of commits to a minimum
  • The commit messages are meaningful and descriptive
  • The change/fix is well documented, particularly in hard-to-understand areas of the code / unit tests
  • Are there any breaking changes in the code, if so are they discussed and did the team agreed to these changes
  • Check that the branch is based on main and is up to date with main
  • Check that the PR targets main
  • There are no merge conflicts and no conflicting Django migrations

How has this been tested?

  • Provided unit tests that will prove the change/fix works as intended
  • Tested the change/fix locally and all unit tests still pass
  • Code coverage is at least 85% (the higher the better)
  • No iSort, Flake8 and SPDX issues are present in the code

@vanbuiten vanbuiten requested a review from 4c0n February 26, 2024 09:03
@vanbuiten vanbuiten self-assigned this Feb 26, 2024
@vanbuiten vanbuiten force-pushed the chore/ordering-on-areas-endpoint branch from 54bfbb6 to 3aeeced Compare February 26, 2024 09:56
@vanbuiten vanbuiten merged commit 7e67f99 into main Feb 27, 2024
3 checks passed
@vanbuiten vanbuiten deleted the chore/ordering-on-areas-endpoint branch February 27, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants