Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From a user: back button non-responsive when editing a note... #456

Closed
bvahedy opened this issue Dec 1, 2019 · 6 comments
Closed

From a user: back button non-responsive when editing a note... #456

bvahedy opened this issue Dec 1, 2019 · 6 comments

Comments

@bvahedy
Copy link

bvahedy commented Dec 1, 2019

From a user:
After editing note: back button doesn't close note. No way to get back to bible.

Expected behavior:
Back button in note window should go back to bible window. Also tapping and holding the device back button should not display the history when viewing the notes.

@tuomas2
Copy link
Contributor

tuomas2 commented Dec 1, 2019

Duplicate of #451?

@tuomas2 tuomas2 added this to the v3.2 milestone Dec 1, 2019
@timbze
Copy link
Contributor

timbze commented Dec 9, 2019

This is duplicate of 451, but not sure about this part below, or if this is matters if it stays this way:

Tapping and holding the device back button should not display the history when viewing the notes.

If this is something that needs to be addressed we should make a new issue out of it I think.

@bvahedy
Copy link
Author

bvahedy commented Dec 9, 2019 via email

@timbze
Copy link
Contributor

timbze commented Dec 9, 2019

I'm thinking we could maybe leave the long press back as is for now, until we work with #188 (show / edit "my notes" as a window (like other translations))
I'm interested to hear Tuomas' thoughts on this.

@bvahedy
Copy link
Author

bvahedy commented Dec 9, 2019 via email

@bvahedy bvahedy removed their assignment Dec 12, 2019
@bvahedy
Copy link
Author

bvahedy commented Dec 12, 2019

Verified fixed in build 321.2

@bvahedy bvahedy closed this as completed Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants