refactor: post serialization simplified #211
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wax911
commented
Mar 12, 2025
| @@ -18,6 +18,7 @@ def __init__(self, *, only: Optional[StrSequenceOrSet] = None, exclude: StrSeque | |||
| super().__init__(only=only, exclude=exclude, many=many, context=context, load_only=load_only, | |||
| dump_only=dump_only, partial=partial, unknown=unknown) | |||
|
|
|||
| @post_load() | |||
There was a problem hiding this comment.
If we don't add @post_load on the contract, the decorator is able to add it but it'll never get triggered, I'm not entirely sure why this happens
wax911
commented
Mar 12, 2025
| self._logger.error(f"Conversion from dictionary failed", exc_info=e) | ||
| raise e | ||
|
|
||
| schema_class._on_post_load = on_post_serialization |
There was a problem hiding this comment.
Basically redefine the contract _on_post_load by assigning it an implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure you've done the following:
developand targetsdevelop(where applicable)Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of
the Apache License.