[4.0] on release, upload .deb as release asset automatically #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Nov 6, 2023
| name: Upload Release .deb | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
This is a fairly alarming permission since it does give the workflow permission to make commits in to the repository. But, to upload a release asset we need this.
spoonincode
commented
Nov 6, 2023
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| -H "Content-Type: application/octet-stream" \ | ||
| --data-binary "@${{steps.getter.outputs.downloaded-file}}" \ | ||
| "https://uploads.github.com/repos/${{github.repository}}/releases/${{github.event.release.id}}/assets?name=${{steps.getter.outputs.downloaded-file}}" |
There was a problem hiding this comment.
I found using curl was easiest here instead of an octokit JS job because the JS API requires loading the whole file in memory if I'm understanding it correctly 😕
linh2931
approved these changes
Nov 6, 2023
greg7mdp
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to leap's release workflow, I guess we'll just have to merge this and hope it works next time we do a release (and tweak accordingly) since I don't have a good way to clearly demonstrate that it works. I have tested it on a private repo though.
Resolves #243