Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable CFL Alias Analysis by default; resolving at least one case of indeterministic build output #305

Closed
wants to merge 2 commits into from
Closed

disable CFL Alias Analysis by default; resolving at least one case of indeterministic build output #305

wants to merge 2 commits into from

Conversation

spoonincode
Copy link
Member

This resolved system contract build indeterminism for me; don't know what the negative consequences are though

@spoonincode
Copy link
Member Author

for an eosio.system.wasm build:
before (with CFL AA): 371557 bytes
this PR (no CFL AA): 371589 bytes

@arhag
Copy link
Member

arhag commented Aug 22, 2024

This should target release/4.1.

@spoonincode
Copy link
Member Author

will rebase and add doc changes on a 4.1 branch

@spoonincode spoonincode deleted the disable_cffaa_default branch August 22, 2024 18:00
@spoonincode
Copy link
Member Author

replaced with #309 on 4.1 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@ericpassmore ericpassmore ericpassmore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spoonincode @arhag @heifner @ericpassmore