Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove disable-subjective-billing option #1209

Merged
merged 1 commit into from
May 24, 2023
Merged

Remove disable-subjective-billing option #1209

merged 1 commit into from
May 24, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented May 22, 2023

The options disable-subjective-p2p-billing and disable-subjective-api-billing cover the same functionality as disable-subjective-billing. disable-subjective-billing simply set the other two options to true. Simplify options by removing this redundant option.

Resolves #1173

@heifner heifner added documentation Improvements or additions to documentation OCI Work exclusive to OCI team labels May 22, 2023
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we announced the deprecation and removal of this option?

@heifner
Copy link
Member Author

heifner commented May 23, 2023

Have we announced the deprecation and removal of this option?

Not yet. @stephenpdeos @bhazzard

@heifner heifner merged commit 0615a25 into main May 24, 2023
@heifner heifner deleted the GH-1173-rm-option branch May 24, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove disable-subjective-billing option
4 participants