[4.0] remove YubiHSM support from keosd #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasons for this removal are well documented in eosnetworkfoundation/mandel#110. That issue did suggest implementing PKCS#11 support as a replacement, however that work will need to be done at a later time. In the meantime I've opened #67 and #68 to track enhancements to keosd wallet providers.
The first commit in this PR is a squashed cherry-pick of the two commits over in the first take of this change, #66. The second commit is an additional removal I missed first time around: since everything consumes openssl via fc, we only need to define these definitions as part of fc's interface.