Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow speculative trx execution in irreversible mode #1030

Closed
heifner opened this issue Nov 13, 2024 · 4 comments · Fixed by #1036
Closed

Allow speculative trx execution in irreversible mode #1030

heifner opened this issue Nov 13, 2024 · 4 comments · Fixed by #1036
Assignees
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Nov 13, 2024

With the introduction of Savanna instant finality, there is now no longer a reason to prevent speculative trx execution on irreversible nodes. Allowing speculative execution on irreversible nodes would allow a local node to be used for multiple purposes.

Particularly exchanges may find this useful. It would allow them to run in irreversible mode, but still submit their trxs to the chain without the need to run a separate node or use a public API.

@greg7mdp
Copy link
Contributor

With the introduction of Savanna instant finality, there is now no longer a reason to prevent speculative trx execution on irreversible nodes

What was the reason pre-Savanna for not executing speculative transactions that Savanna invalidates?

@heifner
Copy link
Member Author

heifner commented Nov 13, 2024

With the introduction of Savanna instant finality, there is now no longer a reason to prevent speculative trx execution on irreversible nodes

What was the reason pre-Savanna for not executing speculative transactions that Savanna invalidates?

The state was consider too old, 300+ blocks behind.

@greg7mdp
Copy link
Contributor

The state was consider too old, 300+ blocks behind.

Makes sense, thanks. Even with Savanna, would it not matter that transactions are validated on a state that is two blocks old (or possibly more)?

@heifner
Copy link
Member Author

heifner commented Nov 13, 2024

The state was consider too old, 300+ blocks behind.

Makes sense, thanks. Even with Savanna, would it not matter that transactions are validated on a state that is two blocks old (or possibly more)?

You can never speculatively execute on the exact state of the produced block. If the node is only one block away instead of two blocks then that is better, but most use cases it will not make any difference.

@bhazzard bhazzard added enhancement New feature or request 👍 lgtm and removed triage labels Nov 14, 2024
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Nov 14, 2024
@heifner heifner self-assigned this Nov 15, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Nov 15, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Nov 15, 2024
heifner added a commit that referenced this issue Nov 15, 2024
heifner added a commit that referenced this issue Nov 15, 2024
… The distributed transaction test now always tests speculative, irreversible, and head.
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Nov 15, 2024
heifner added a commit that referenced this issue Nov 19, 2024
…_block >= pending_block since blocks are not processed until they become irreversible
heifner added a commit that referenced this issue Nov 19, 2024
…rxs in irreversible mode when not in savanna
heifner added a commit that referenced this issue Nov 19, 2024
heifner added a commit that referenced this issue Nov 21, 2024
Support speculative trx execution in irreversible mode
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants