Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update p2p-auto-bp-peer for finalizers #1227

Closed
heifner opened this issue Mar 4, 2025 · 0 comments · Fixed by #1244
Closed

Update p2p-auto-bp-peer for finalizers #1227

heifner opened this issue Mar 4, 2025 · 0 comments · Fixed by #1244
Assignees
@heifner
Labels
👍 lgtm
Milestone
Spring v1.2.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Mar 4, 2025

The existing p2p-auto-bp-peer was created for legacy pre-savanna consensus. With the new Savanna consensus it is important to be connected to all finalizers. Update the p2p-auto-bp-peer to remain connected to all configured bp peers that are in the top 21.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Mar 4, 2025
@heifner heifner self-assigned this Mar 4, 2025
@heifner heifner added this to the Spring v1.2.0-rc1 milestone Mar 4, 2025
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Mar 4, 2025
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Change auto-bp-peer to maintain connections to all active blo…
d763969 
…ck proposers instead of just a few. Remove requirement to be configured as a block producer.
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Update integration test for new bp auto peering. Also fixed i…
2e6b4e1 
…ssue with the test not actually testing anything because python peers = peers.sort() meant that peers==None.
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
Merge branch 'GH-1239-p2p-stuck-in-head-catchup-main' into GH-1227-au…
7def374 
…to-bp-peer
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Remove tmp debug logging
e30e4fa
@heifner heifner mentioned this issue Mar 7, 2025
Merged
@heifner heifner linked a pull request Mar 7, 2025 that will close this issue
P2P: Update p2p-auto-bp-peer for Savanna #1244
Merged
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Consider a node in sync when it is out of lib catchup since S…
99e3317 
…avanna head is so close to lib and a node can temporarily fall back into head catchup on slight block delays.
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Break out of test on first error
51f2c54
@heifner heifner mentioned this issue Mar 7, 2025
Open
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Rename is_in_sync() to not_lib_catchup() to more closing matc…
eac92e4 
…h its implementation.
heifner added a commit that referenced this issue Mar 7, 2025
@heifner
GH-1227 Add comment
0a5823c
heifner added a commit that referenced this issue Mar 10, 2025
@heifner
GH-1227 Use is_lib_catchup() instead of not_lib_catchup()
3111e01
heifner added a commit that referenced this issue Mar 11, 2025
@heifner
GH-1227 Update comments
a1f55d6
heifner added a commit that referenced this issue Mar 11, 2025
@heifner
Merge pull request #1244 from AntelopeIO/GH-1227-auto-bp-peer
b929322 
P2P: Update p2p-auto-bp-peer for Savanna
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm
Projects
Team Backlog
Status: Done
Milestone
Spring v1.2.0-rc1
Development

Successfully merging a pull request may close this issue.

P2P: Update p2p-auto-bp-peer for Savanna AntelopeIO/spring
3 participants
@heifner @enf-ci-bot @BenjaminGormanPMP