Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new unittest to validate current finalizer safety file i/o #764

Closed
greg7mdp opened this issue Sep 12, 2024 · 1 comment · Fixed by #809 or #807
Closed

Add new unittest to validate current finalizer safety file i/o #764

greg7mdp opened this issue Sep 12, 2024 · 1 comment · Fixed by #809 or #807
Assignees
Milestone

Comments

@greg7mdp
Copy link
Contributor

  • finalizer_tests/finalizer_safety_file_versioning validates loading older versions. Also validate current version: we should be able to load the reference file, save the fsi info, and end up with exactly the same bytes.
  • also check that the current version of safety.dat file committed to the repo can be loaded on nodeos startup and saved on nodeos shutdown (assuming no voting or block processing) without changing the contents.
@arhag arhag added 👍 lgtm and removed triage labels Sep 16, 2024
@arhag arhag added this to the Spring v1.0.2 milestone Sep 16, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Sep 19, 2024
@greg7mdp greg7mdp changed the title Add new unittest to check validate current finalizer safety file i/o Add new unittest to validate current finalizer safety file i/o Sep 19, 2024
@greg7mdp
Copy link
Contributor Author

greg7mdp commented Sep 20, 2024

Regarding the second check:

  • also check that the current version of safety.dat file committed to the repo can be loaded on nodeos startup and saved on nodeos shutdown (assuming no voting or block processing) without changing the contents.

We can check that the reference file can be loaded by nodeos on startup, but it is saved only when voting (not at nodeos shutdown), so we cannot check "and saved on nodeos shutdown (assuming no voting or block processing) without changing the contents."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment