Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PH: Change default transaction generator trx expiration #1121

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

heifner
Copy link
Member

@heifner heifner commented Jan 24, 2025

The transaction generator, used in performance testing, default transaction expiration was set to 60 minutes. 60 minutes is the also the default maximum transaction expiration limit. Since the comparison is <= pending_block_time this can fail.

Changed the default to 30 minutes which is more than enough. Seems, any performance test that takes 30 minutes to get a transaction to execute should be considered a failure.

EOS_ASSERT( trx.expiration.to_time_point() <= pending_block_time() + fc::seconds(chain_configuration.max_transaction_lifetime),

Resolves #1093

…seconds. 60 minutes is too close to the limit and can sometimes fail.
@heifner heifner added the OCI Work exclusive to OCI team label Jan 24, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Tests
component: Performance Harness
summary: Decrease transaction expiration to more reasonable 30 minutes.
Note:end

@heifner heifner merged commit 85e8407 into main Jan 27, 2025
36 checks passed
@heifner heifner deleted the GH-1093-test-exp-trx branch January 27, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: Transaction Expiration Too Far
4 participants