[1.1.0] Fix account billing on eos-vm-oc interrupt #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
added
bug
greg7mdp
approved these changes
Feb 12, 2025
| @@ -64,7 +64,7 @@ namespace eosio::chain { | |||
|
|
|||
| auto sw = executed_action_receipts.store_which(); | |||
| executed_action_receipts = action_digests_t{sw}; | |||
| bill_to_accounts.clear(); | |||
| // bill_to_accounts is only updated in init() | |||
There was a problem hiding this comment.
Suggested change
| // bill_to_accounts is only updated in init() | |
| // bill_to_accounts should only be updated in init() |
linh2931
reviewed
Feb 12, 2025
linh2931
approved these changes
Feb 12, 2025
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not clear
bill_to_accountsintransaction_context::reset()asbill_to_accountsis only modified duringtransaction_context::init(). Thisclear()was causing accounts to not be billed for CPU/NET when the transaction was interrupted by oc compile. This difference in recorded resource usage caused a difference in the integrity hash between a node that was interrupted vs one that was not.Clean chicken-dance run with this PR.
Resolves #1152