Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.1] Fix get_info not available on non-chain API endpoints #1195

Merged
merged 3 commits into from
Feb 24, 2025
Merged

[1.1.1] Fix get_info not available on non-chain API endpoints #1195

merged 3 commits into from
Feb 24, 2025

Conversation

linh2931
Copy link
Member

@linh2931 linh2931 commented Feb 24, 2025 •
edited
Loading

get_info was mistakenly removed from node category (#920) and caused it not available on non-chain API endpoints

This PR

  • Moves it back to node category
  • Fixes a bug of plugin_http_api_test that it does not exit with an exit value. That causes plugin_http_api_test to always appear successful even though it fails
  • Add a test of get_info on non-chain API endpoint

Resolves #1194

@heifner heifner changed the title Fix get_info available on non-chain API endpoints [1.1.1] Fix get_info available on non-chain API endpoints Feb 24, 2025
@linh2931 linh2931 merged commit 39974e9 into release/1.1 Feb 24, 2025
36 checks passed
@linh2931 linh2931 deleted the get_info_category_fix branch February 24, 2025 19:10
@linh2931 linh2931 changed the title [1.1.1] Fix get_info available on non-chain API endpoints [1.1.1] Fix get_info not available on non-chain API endpoints Feb 24, 2025
@linh2931 linh2931 mentioned this pull request Feb 24, 2025
Merged
@ericpassmore ericpassmore added the bug The product is not working as was intended. label Feb 25, 2025
@ericpassmore
Copy link
Contributor

Note:start
category: Other
component: Internal
summary: Restore get_info to non-chain API endpoints.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heifner heifner heifner approved these changes

@spoonincode spoonincode spoonincode approved these changes

@greg7mdp greg7mdp Awaiting requested review from greg7mdp

Assignees
No one assigned
Labels
bug The product is not working as was intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@linh2931 @ericpassmore @heifner @spoonincode