avoid memset & memcpy on non-trivially copyable fc::variant to eliminate a bunch of warnings
#1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
commented
Mar 7, 2025
| double _data; ///< Alligned according to double requirements | ||
| char _type[sizeof(void*)]; ///< pad to void* size | ||
| //enough room to store pointers, doubles, uint64s. doubled to allow 1 extra byte to store type at the end | ||
| alignas(double) std::array<char, std::max(sizeof(uintmax_t ), sizeof(double)) * 2> _data = {}; |
There was a problem hiding this comment.
afaict we just need a +1 but I doubled it so it fits nicely in 16 byte register (and 16 bytes is what it was previously too)
linh2931
approved these changes
Mar 7, 2025
heifner
approved these changes
Mar 10, 2025
greg7mdp
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang20 is firing off a megaton of warnings such as
and
Not sure if anyone has strong opinions on proper way to resolve the warning (besides a larger refactor). I think we could keep the memcpy/memset and explicitly cast the pointers but that seems more hacky than using a std::array like done here.