SC: Implement the core functionalities of sync calls #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh2931
commented
Mar 12, 2025
| @@ -26,17 +26,21 @@ struct platform_timer { | |||
| callback still execute if the timer expires and stop() is called nearly simultaneously. | |||
| However, set_expiration_callback() is synchronized with the callback. | |||
| */ | |||
| void set_expiration_callback(void(*func)(void*), void* user) { | |||
| void set_expiration_callback(void(*func)(void*), void* user, bool appending = false) { | |||
There was a problem hiding this comment.
If the approach is deemed OK, I will replace this default parameter with regular parameter, and define an enum for the boolean, like {multi_callbacks_allowed, multi_callbacks_disallowed}.
linh2931
commented
Mar 12, 2025
|
|
||
| execute(context, bkend, exec_ctx, wasm_alloc, fn); | ||
| } | ||
|
|
||
| void apply(apply_context& context) override { |
There was a problem hiding this comment.
I will refactor apply to reuse the new execute method.
…nc_call entry point
…th sync_call_context to better reflect what they are and make sync_call_context fit into apply_context better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the core functionalities of sync calls, in particular the
callhost function. The Unit tests show basic call flows are working:Notes for reviewing:
libraries/chain/webassembly/sync_call.cpp,libraries/chain/apply_context.cppandlibraries/chain/webassembly/runtimes/eos-vm.cppto revieweosvm-ocnot working yet. very minor OC tweaks to allow for nested Executor execution #1043 (sync call unit tests skip eosvm-oc)transaction_checktime_timerrelated changes are correctiterator_cacheinapply_contextafter a sync call #1252Resolves #1214