Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: Remove hotstuff references #30

Merged
merged 7 commits into from
Apr 19, 2024
Merged

IF: Remove hotstuff references #30

merged 7 commits into from
Apr 19, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Apr 15, 2024

Various renaming to remove references to hotstuff nomenclature.

Resolves #12

@heifner heifner added the OCI Work exclusive to OCI team label Apr 15, 2024
@heifner heifner linked an issue Apr 15, 2024 that may be closed by this pull request
Clean up hotstuff directory after unification #12
Closed
@heifner heifner requested review from linh2931 and greg7mdp April 15, 2024 17:19
linh2931
linh2931 reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@linh2931 linh2931 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

@heifner
Copy link
Member Author

heifner commented Apr 15, 2024

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

They could be, but seems nice to keep it seperated.

@linh2931
Copy link
Member

Do we still need finality directory? Can everything under original hotstuff be moved to chain?

They could be, but seems nice to keep it seperated.

OK. It's just a style.

@greg7mdp
Copy link
Contributor

If we are going to keep the finality directories, probably we should move finality_core to them.

Base automatically changed from GH-14-vote-loggin to savanna April 19, 2024 13:29
@heifner heifner merged commit 64b77f4 into savanna Apr 19, 2024
36 checks passed
@heifner heifner deleted the GH-12-cleanup branch April 19, 2024 14:40
@ericpassmore
Copy link
Contributor

Note:start
group: IF
category: INTERNALS
summary: Make code more readable, by removing hotstuff nomenclature.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg7mdp greg7mdp greg7mdp approved these changes

@linh2931 linh2931 linh2931 approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up hotstuff directory after unification
4 participants
@heifner @linh2931 @greg7mdp @ericpassmore