[1.0.1] Handle block invariant checks during replay appropriately and in particular ensure --force-all-checks is respected #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Sep 6, 2024
heifner
requested changes
Sep 6, 2024
arhag
reviewed
Sep 6, 2024
…nts and verify_qc; rename several functions
heifner
requested changes
Sep 6, 2024
greg7mdp
approved these changes
Sep 6, 2024
heifner
approved these changes
Sep 7, 2024
|
Note:start |
heifner
reviewed
Sep 7, 2024
|
|
||
| // verify the QC proof against the claimed block | ||
| bsp->verify_qc(qc_proof); | ||
| return qc_proof; | ||
| } |
There was a problem hiding this comment.
Be explicit with optional type otherwise you don't get return value optimization
There was a problem hiding this comment.
Thanks. Did not notice this before I pressed the green button. Will do a followup PR tomorrow.
linh2931
commented
Sep 9, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently QC block extension and finality header extension are not verified during replay.
This PR performs all the basic checks of Legacy, Transition, and Proper Savanna blocks during replay. If
--force-all-checksis specified, a complete QC validation is performed.Resolves #693