Remove FluentAssertions #2459
Merged
Remove FluentAssertions #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete migration from FluentAssertions to Shouldly. Resolves App-vNext#2450.
martincostello
added
CI/build
dependencies
Fix broken file header.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
- Coverage 85.36% 85.35% -0.02%
==========================================
Files 312 312
Lines 7464 7464
Branches 1121 1121
==========================================
- Hits 6372 6371 -1
- Misses 907 908 +1
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use `Stopwatch.StartNew()` instead of creating one then manually starting it.
|
@martincostello it looks like there are still some dangling references that should be removed — https://github.com/search?q=repo%3AApp-vNext%2FPolly%20fluentassertions&type=code |
|
Thanks - I'll remove two of them, but the third is in the release notes so is still historically accurate. |
martincostello
added a commit
that referenced
this pull request
Mar 10, 2025
martincostello
added a commit
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete migration from FluentAssertions to Shouldly.
Resolves #2450.