fix: LMSDEV-6741 Query current language instead of user language #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning for this change: - We need $SESSION->forcelang to be set in order for the filter chain to work properly. This gets set by calling the moodle lib function force_current_language. - mod_customcert was not calling force_current_language IF the user's language was equal to the certificate's forced language. - This caused the following issue: A user with language en, in a session where the language was set to es_mx, viewing the forced-English-language certificate, would see a spanish section title instead of an English section title. - As a fix, we should not worry about what the user's "preferred" language is when we're deciding whether to force a language. All we care about is the current session's language.
sayoder-aprende
changed the title
sayoder-aprende
changed the title
samsmucker
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning for this change:
work properly. This gets set by calling the moodle lib function
force_current_language.
language was equal to the certificate's forced language.
where the language was set to es_mx, viewing the
forced-English-language certificate, would see a spanish section title
instead of an English section title.
language is when we're deciding whether to force a language. All we
care about is the current session's language.