mb/docstrings #107
Merged
mb/docstrings #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugobuddel
reviewed
Feb 12, 2025
| @@ -34,7 +34,8 @@ def inner(): | |||
| workflows = ['metis_lm_img_wkf', 'metis_lm_ifu_wkf', 'metis_pupil_imaging_wkf', 'metis_wkf'] | |||
|
|
|||
|
|
|||
| class DisabledTestEDPS: | |||
| @pytest.mark.edps | |||
| class TestEDPS: | |||
| @pytest.mark.parametrize('workflow_name', workflows) | |||
There was a problem hiding this comment.
I cannot comment on unchanged lines unfortunately, but the workflows should not include metis_lm_ifu_wkf, just metis_ifu_wkf
There was a problem hiding this comment.
Thanks, I spent two hours digging into this.
hugobuddel
reviewed
Feb 12, 2025
metisp/pymetis/src/pymetis/recipes/img/metis_lm_img_basic_reduce.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugo Buddelmeijer <[email protected]>
astronomyk
approved these changes
Feb 13, 2025
|
We forgot to create the corresponding Pull Request for METIS_Pipeline_Test_Data, so I took the liberty to create it: AstarVienna/METIS_Pipeline_Test_Data#11 More importantly we should also update METIS_Simulations, because the metis_lm_img_calibrate.sof we are planning to deliver will not actually work with the pipeline we are planning to deliver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liberally peppering everything with type annotations, docstring, and cutting all forgotten loose ends.