Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Python part ESO-compatible #48

Merged
merged 18 commits into from
Oct 17, 2024
Merged

Make Python part ESO-compatible #48

merged 18 commits into from
Oct 17, 2024

Conversation

hugobuddel
Copy link
Contributor

Supersedes #47

Move the Python files from the 'prototypes' directory into the proper locations:

  • general python code: metisp/pymetis/src
  • recipes: metisp/pyrecipes
  • workflows: metisp/workflows

Also add all required cmake and make files.

This is based on the iiinstrument-dev-pymodules branch.

The cmake files are configured such that only out-of-source builds are allowed. Use with something like

pip install schema
cmake -S metisp -B build/ --install-prefix=/tmp/wherever
make -C build
make -C build install
pyesorex --recipe-dir=/tmp/wherever/lib64/esopipes-plugins/ --recipes

should give you something like

[ INFO  ] pyesorex: This is PyEsoRex, version 1.0.1-alpha1.

     ***** ESO Recipe Execution Tool, Python version 1.0.1-alpha1 *****

List of available recipes:

  metis_det_lingain     : Measure detector non-linearity and gain
  metis_abstract_base   : Abstract-like base class for METIS recipes
  metis_ifu_calibrate   : Reduce raw science exposures of the IFU.
  metis_lm_basic_reduction: Basic science image data processing
  metis_n_img_flat      : Create master flat for N band detectors
  metis_lm_img_flat     : Create master flat for L/M band detectors
  metis_det_dark        : Create master dark
  metis_ifu_telluric    : Derive telluric absorption correction and optionally flux calibration
  metis_ifu_reduce      : Reduce raw science exposures of the IFU.

@hugobuddel hugobuddel requested a review from sesquideus October 16, 2024 20:08
@hugobuddel hugobuddel changed the title Hb/pymetis3 Make Python part ESO-compatible Oct 17, 2024
@sesquideus sesquideus closed this Oct 17, 2024
Copy link
Contributor

@sesquideus sesquideus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installed and ran successfully with pipenv's cmake 3.30.4 (for whatever reason it's /tmp/wherever/lib/esopipes-plugins/metis-0.0.1/ for me. I also understand the new package directory structure and it looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants