Mb/ifu missing #72
Merged
Mb/ifu missing #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps ask one of the other recipe writers to review? Looks good to me though |
|
Tested my assigned metis_ifu_rsrf recipe with some dummy input files and it runs fine - so it looks good to merge from my side... |
janusbrink
reviewed
Dec 18, 2024
janusbrink
approved these changes
Dec 18, 2024
|
Great @sesquideus ! We should make sure we add any new (/newly working) recipes to
Perhaps we're at the stage where we can remove the I placed that target there because the other recipes were not yet complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added more recipes whose implementation was missing (
metis_ifu_*).Also many more tests and we're now skipping those that refer to missing files (again in IFU).