Cy/issue 0070 #80
Cy/issue 0070 #80
Conversation
|
@hugobuddel Let me know if I can merge it. Thanks. |
There was a problem hiding this comment.
Thank you Chi-Hung!
Note that you should feel free to 'request' me as a reviewer by pressing the button at the top right of the PR page if you think a review specifically from me would be useful.
I highlighted two things that need to be changed at some point. I think the best moment is to do that now, but you can also merge this and do it later.
| @@ -22,7 +22,7 @@ Including the following two line in your .bashrc | |||
| export METIS_SOFTPATH='<path_of_METIS_pipeline>' | |||
| export PYTHONPATH=$METIS_SOFTPATH | |||
| export SOF_DATA='<path_to_data>' | |||
| export PYCPL_RECIPE_DIR='<path_of_METIS_pipeline>/prototypes/recipes/' | |||
| export PYCPL_RECIPE_DIR='<path_of_METIS_pipeline>/metisp/pymetis/src/pymetis/recipes/' | |||
There was a problem hiding this comment.
| export PYCPL_RECIPE_DIR='<path_of_METIS_pipeline>/metisp/pymetis/src/pymetis/recipes/' | |
| export PYCPL_RECIPE_DIR='<path_of_METIS_pipeline>/metisp/pyrecipes/' |
pyrecipes is the official path that should be used. So please make sure all recipes are actually imported there
| from . import metis_keywords as metis_kwd | ||
|
|
||
| # Detector linearity calibration classification | ||
| detlin_class = classification_rule("DETLIN_2RG_RAW", |
There was a problem hiding this comment.
These classifications now all should have lm in their name, because they are not in an lm-specific file anymore. That is, how should we call the DETLIN_GEO_RAW now?
I think it would be easiest to just reuse the tag name, e.g. detlin_2rg_raw.
chyan26
force-pushed
the
cy/issue-0070
branch
from
2585f95 to
9f79313
Compare
chyan26
force-pushed
the
cy/issue-0070
branch
from
9f79313 to
c9ecdfa
Compare
|
@chyan26 , I did expect you to at least acknowledge the comments that I did make. Like add a comment or so, but the suggestion on the README you could have simply accepted by pressing the "Accept Suggestion" button. You don't have to accept them, but I do think it is rude to just ignore my comments completely. |
I have created a master workflow as well as separated keywords, datasources and classifications. I want to merge it.