Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mb/testament #84

Merged
merged 6 commits into from
Jan 27, 2025
Merged

Mb/testament #84

merged 6 commits into from
Jan 27, 2025

Conversation

sesquideus
Copy link
Contributor

Mostly just a lot of tests. Fixed everything that failed where tests were inconsistent before.

@hugobuddel hugobuddel self-requested a review January 27, 2025 06:00
hugobuddel
hugobuddel approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm not really sure what the pupil imaging recipe should actually do, but this PR does not really change that, so this is fine.

@sesquideus sesquideus requested review from chyan26 and astronomyk and removed request for chyan26 and astronomyk January 27, 2025 08:21
@sesquideus sesquideus merged commit 148cc13 into main Jan 27, 2025
2 checks passed
@sesquideus sesquideus deleted the mb/testament branch January 27, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugobuddel hugobuddel hugobuddel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesquideus @hugobuddel