-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding updated version of ifu_tellruic recipe #94
Conversation
Please check whether the tests pass before assigning a reviewer, or better, run the tests locally through
https://github.com/AstarVienna/METIS_Pipeline/actions/runs/13134572205/job/36646955413 |
Yes, sorry, Actually I didn't want to add ou as reviewer :-) |
I didn't necessarily intend to actually review, I just got a notification about the PR and thought maybe it would be helpful if you know how to run the tests locally. |
Yes, that's indeed a good suggestion to make it locally. I'll try to install everything now. But what I meant is I didn't want to bother you with lots of messages :-). Actually I was surprised that you have been noticed about the crashed tests |
-Added more pytests for metis_ifu_rsrf
I went through everything and sequentially eliminated all problems I could find. It gave me an idea how to abstract away a few things in the |
Thanks for eliminating the problems. Does this mean we're done for now? |
I think it's fine. Moreover, some of the inputs I created here can be reused elsewhere now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Here's the latest version of the ifu_telluric resipe :-)