Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runnotebooks.sh by sorting the notebooks #535

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Conversation

hugobuddel
Copy link
Collaborator

untested

@hugobuddel hugobuddel requested a review from teutoburg January 28, 2025 09:20
@hugobuddel
Copy link
Collaborator Author

This should fix the failing ScopeSim_Data runs, e.g. https://github.com/AstarVienna/ScopeSim_Data/actions/runs/13004085952/job/36267864985 fails because it starts with 3_custom_effects.ipynb.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.00%. Comparing base (7e72629) to head (cd33aaf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files          66       66           
  Lines        8216     8216           
=======================================
  Hits         6327     6327           
  Misses       1889     1889           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't have any negative consequences to sort them I guess...

@hugobuddel hugobuddel merged commit 74299f7 into main Jan 28, 2025
22 checks passed
@hugobuddel hugobuddel deleted the hb/fixrunnotebooks2 branch January 28, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants