Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fp mask emission #583

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix fp mask emission #583

merged 1 commit into from
Mar 10, 2025

Conversation

oczoske
Copy link
Collaborator

@oczoske oczoske commented Mar 10, 2025

This fixes the flux from the opaque parts of the focal-plane mask. We had used erroneously a high reflectivity for the mask, whereas the conservative case should use a high emissivity. In fact, using Eq.(17) of RvB's document, the intensity from the mask is independent of the emissivity and is just pure black-body intensity.

@oczoske oczoske merged commit 7823ad4 into main Mar 10, 2025
20 checks passed
@oczoske oczoske deleted the oc/wcu/fpmask_flux branch March 10, 2025 15:23
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (8eefa0e) to head (ab91b47).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   76.85%   76.85%   -0.01%     
==========================================
  Files          69       69              
  Lines        8572     8571       -1     
==========================================
- Hits         6588     6587       -1     
  Misses       1984     1984              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant