Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit scipy version to below 1.15.0 #590

Closed
wants to merge 2 commits into from
Closed

Conversation

teutoburg
Copy link
Contributor

Our RTD build fails with scipy >= 1.15.0 because we use the deprecated scipy.misc module somewhere, which has been removed in scipy 1.15.0. Ultimately, we should remove that, wherever it is, but for now at least make sure the incompatible version cannot be installed.

Our RTD build fails with scipy >= 1.15.0 because we use the deprecated `scipy.misc` module somewhere, which has been removed in scipy 1.15.0. Ultimately, we should remove that, wherever it is, but for now at least make sure the incompatible version cannot be installed.
@teutoburg teutoburg added the dependencies Related to or updating any dependencies label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (b5257b7) to head (af1ee44).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #590   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          69       69           
  Lines        8571     8571           
=======================================
  Hits         6587     6587           
  Misses       1984     1984           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg marked this pull request as ready for review March 11, 2025 16:18
@teutoburg teutoburg requested a review from hugobuddel March 11, 2025 16:18
@oczoske
Copy link
Collaborator

oczoske commented Mar 11, 2025

As far as I can see it is only used in irdb/METIS/tests/norun_test_ScopeSim_MET_IMG_LM.py: from scipy.misc import face (a racoon!). It seems to have been available as scipy.datasets.face since v1.12 or so.

@oczoske
Copy link
Collaborator

oczoske commented Mar 11, 2025

But the actual culprit seems to be ScopeSim/docs/source/5_liners/source_from_images.md. I've fixed that in main. If it passes, I would suggest discarding this PR.

@teutoburg
Copy link
Contributor Author

I remember ditching the old raccoon ages ago, that's one of the reasons how we cane across pooch if I remember correctly (for downloading and caching the image). Now I'm wondering if the workflow uses an old version somehow...

@teutoburg
Copy link
Contributor Author

Docs build passed with scipy 1.15.2 in #593, so it seems the issue is now fixed and this PR is no longer needed 👍

@teutoburg
Copy link
Contributor Author

I didn't have the time earlier to see where the offending module was actually imported and thought it might be a lot worse...

@teutoburg teutoburg closed this Mar 11, 2025
@teutoburg teutoburg deleted the fh/no-scipy-1.15 branch March 11, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to or updating any dependencies
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants