-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit scipy version to below 1.15.0 #590
Conversation
Our RTD build fails with scipy >= 1.15.0 because we use the deprecated `scipy.misc` module somewhere, which has been removed in scipy 1.15.0. Ultimately, we should remove that, wherever it is, but for now at least make sure the incompatible version cannot be installed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 69 69
Lines 8571 8571
=======================================
Hits 6587 6587
Misses 1984 1984 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
As far as I can see it is only used in |
But the actual culprit seems to be |
I remember ditching the old raccoon ages ago, that's one of the reasons how we cane across |
Docs build passed with scipy 1.15.2 in #593, so it seems the issue is now fixed and this PR is no longer needed 👍 |
I didn't have the time earlier to see where the offending module was actually imported and thought it might be a lot worse... |
Our RTD build fails with scipy >= 1.15.0 because we use the deprecated
scipy.misc
module somewhere, which has been removed in scipy 1.15.0. Ultimately, we should remove that, wherever it is, but for now at least make sure the incompatible version cannot be installed.