Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

[AUD-25] Update terser #153

Merged
merged 1 commit into from
Dec 22, 2020
Merged

[AUD-25] Update terser #153

merged 1 commit into from
Dec 22, 2020

Conversation

raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Dec 21, 2020

Description

This might fix it?

Noticed some references to older tersers in package-lock, seems like maybe this issue was fixed facebook/create-react-app#6334 (comment)

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
npm run build:prod

@audius-infra
Copy link
Collaborator

Preview this change https://frontend-demo.audius.co/rj-terser

Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so! If it fixes it let's remember to then go change our Circle box sizes down to what they were before this madness

@raymondjacobson raymondjacobson merged commit 3bceb45 into master Dec 22, 2020
@raymondjacobson raymondjacobson deleted the rj-terser branch December 22, 2020 03:15
sliptype pushed a commit that referenced this pull request Dec 29, 2021
* [AUD-1067] Add collectible share button

* Ignore silent switch
sliptype pushed a commit that referenced this pull request Feb 11, 2022
sliptype pushed a commit that referenced this pull request Feb 11, 2022
* [AUD-1067] Add collectible share button

* Ignore silent switch
sliptype pushed a commit that referenced this pull request Feb 12, 2022
sliptype pushed a commit that referenced this pull request Feb 12, 2022
* [AUD-1067] Add collectible share button

* Ignore silent switch
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Failed to minify the bundle" error on build (related to Terser)
3 participants