improve tx forwarding race condition #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phelpsdb
reviewed
Mar 5, 2025
Comment on lines
+22
to
+25
| func (c *Cache) CurrentHeight() int64 { | ||
| return atomic.LoadInt64(&c.currentHeight) | ||
| } | ||
|
|
There was a problem hiding this comment.
In my pr I'm actually changing currentHeight to be an atomic.Int64 for more ergonomic use, thoughts?
There was a problem hiding this comment.
no preference, I think I like it typed how you did so i'll deal with the conflicts!
Comment on lines
+128
to
+129
| // exclude deadlines that are more than 120 blocks behind the current block | ||
| deadline = currentBlock + 10 |
There was a problem hiding this comment.
Seems misleading, we're not actually excluding the deadline in this condition. Should the comment read "exclude deadlines that are more than 120 blocks behind the current block unless transaction is recent (came from syncing node)"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a deadline, submitted_at, and forwarded_from to the forward tx request
uses these to implement some gating at the reception level so old txs get ignored and syncing nodes can still send them
if a tx has a deadline too far the receiving node sets it back to 10 blocks away
if it's from a long time ago blockwise but the timestamp is recent then the node accepts it, likely from syncing node. this should be hardened later