-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EMSUSD-1644 Adds a cutom gizmo shape and geometry #4140
base: dev
Are you sure you want to change the base?
Conversation
AramAzhari-adsk
commented
Feb 28, 2025
- Adds a gizmo shape node and a gizmo geometry override. The gizmo shape node can be generated like a normal Maya node and it can be added as a child of any proxy node.
- Added a collection of geometry shapes.
- Fixes an issue where the dome light interface is not being populated with the guide radius attribute
- Added a new test for the new light gizmos.
- Conditioned the relevant tests to skip or include based on the Maya fix level (mayaUtils.ufeSupportFixLevel()).
- Adds a gizmo shape node and a gizmo geometry override. The gizmo shape node can be generated like a normal Maya node and it can be added as a child of any proxy node. - Added a collection of geometry shapes. - Fixes an issue where the dome light interface is not being populated with the guide radius attribute - Added a new test for the new light gizmos. - Conditioned the relevant tests to skip or include based on the Maya fix level (mayaUtils.ufeSupportFixLevel()).
@@ -128,6 +130,17 @@ def testPoints(self): | |||
|
|||
self._RunTest() | |||
|
|||
@unittest.skipUnless(mayaUtils.ufeSupportFixLevel() >= 9, 'Requires parent command fix in Maya.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran all tests for fix level = 9 locally and they all passed.
` 99% tests passed, 4 tests failed out of 319
Label Time Summary:
Debugging = 0.00 sec*proc (1 test)
MayaUsd = 337.14 sec*proc (14 tests)
MayaUsdApi = 28.14 sec*proc (2 tests)
fileio = 421.37 sec*proc (29 tests)
fileio_utils = 28.33 sec*proc (2 tests)
interactive = 3130.47 sec*proc (49 tests)
nodes = 90.55 sec*proc (6 tests)
pxrUsdMayaGL = 1183.42 sec*proc (17 tests)
translators = 2012.59 sec*proc (112 tests)
ufe = 1078.94 sec*proc (61 tests)
undo = 31.02 sec*proc (2 tests)
usdPreviewSurface = 27.06 sec*proc (2 tests)
utils = 150.42 sec*proc (6 tests)
vp2RenderDelegate = 1574.21 sec*proc (25 tests)
Total Test time (real) = 246.63 sec
The following tests did not run:
14 - _Interactive_Maya (Disabled)
The following tests FAILED:
208 - testUsdExportUnits (Failed)
224 - testUsdExportUserTaggedAttributes (Failed)
285 - testUsdExportAssignedMaterials (Failed)
319 - TestAdditionalTranslators (Failed)
Errors while running CTest
Test project python3/build/RelWithDebInfo
Start 208: testUsdExportUnits
Start 224: testUsdExportUserTaggedAttributes
Start 285: testUsdExportAssignedMaterials
Start 319: TestAdditionalTranslators
1/4 Test #208: testUsdExportUnits .................. Passed 7.83 sec
2/4 Test #224: testUsdExportUserTaggedAttributes ... Passed 8.10 sec
3/4 Test #285: testUsdExportAssignedMaterials ...... Passed 8.12 sec
4/4 Test #319: TestAdditionalTranslators ........... Passed 9.00 sec
100% tests passed, 0 tests failed out of 4
Label Time Summary:
translators = 24.05 sec*proc (3 tests)
Total Test time (real) = 9.93 sec
Building with settings:
Source directory Redacted\maya-usd
Workspace directory C:\Gitstuff\python3
Build directory C:\Gitstuff\python3\build\RelWithDebInfo
Install directory C:\Gitstuff\python3\install\RelWithDebInfo\MayaUSD
Variant RelWithDebInfo
Python Debug Off
CMake generator Ninja
Build arguments ['-DCMAKE_MAKE_PROGRAM=Redacted/maya/Redacted/Windows/ninja/1.10.2/ccacdf8/ninja.exe', '-DPYTHON_INCLUDE_DIR=Redactedmaya/builds/main/maya/build/RelWithDebInfo/runTime/include/Python311/Python', '-DPython_EXECUTABLE=Redactedmaya/builds/main/maya/build/RelWithDebInfo/runTime/bin/mayapy.exe', '-DPYTHON_LIBRARIES=Redactedmaya/builds/main/maya/build/RelWithDebInfo/runTime/lib/python311.lib', '-DBUILD_WITH_PYTHON_3=ON', '-DPython3_VERSION=3.11', '-DBUILD_WITH_PYTHON_3_VERSION=3.11']
Stages arguments ['test']
CTest arguments ['-E testUsdReferenceAssemblySelection|testUsdMayaAppDir', '--parallel 32']
#####################################################################################
log date: 2025-03-02 11:57
commit sha: 946fc8c1625130c177facb550893c863df37c65a
commit date: Sun Mar 2 08:11:39 2025 -0500
#####################################################################################
cmake --build . --config RelWithDebInfo --target install -- -j32
#####################################################################################
log date: 2025-03-02 11:57
commit sha: 946fc8c1625130c177facb550893c863df37c65a
commit date: Sun Mar 2 08:11:39 2025 -0500
#####################################################################################
ctest --output-on-failure --timeout 500 -C RelWithDebInfo -E testUsdReferenceAssemblySelection|testUsdMayaAppDir --parallel 32
WARNING: One (or more) tests failed, re-running only failed tests.
Successfully re-ran failed tests!
Success running MayaUsd tests!
Finished stage: Ecg-Maya-Usd/test [Windows (RelWithDebInfo)] in 4.3 seconds (4.30 minutes)
----------------------------------------`
plugin/adsk/plugin/plugin.cpp
Outdated
@@ -49,10 +51,19 @@ | |||
#include <pxr/base/plug/registry.h> | |||
#include <pxr/base/tf/envSetting.h> | |||
|
|||
#include <maya/M3dView.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need it here..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, removed in latest update.
class MAYAUSD_PLUGIN_PUBLIC LinePrimitive : public PrimitiveData | ||
{ | ||
public: | ||
LinePrimitive(float length = 1, unsigned int up = 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it be better to have an enum for the up axis? Otherwise it can be hard to tell which is which
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a low level class closer to what the gpu consumes for drawing shapes. Similar to MUIDrawManager we'd like to reduce the amount of operations. Given that the incoming data is an int, it makes sense not to have to cast it to an enum. I think it should be kept without having an enum.
These tests timed out:
|