EMSUSD-2084 - adding or removing of items in collections should respect the edit restrictions as other attributes #4143
Conversation
haberlu
force-pushed
the
haberlu/EMSUSD-2084_edit_restrictions_in_relationships
branch
from
d421a20 to
83d1799
Compare
|
Added Pierre as reviewer as he knows a lot more about edit restrictions that I do. |
| //! \param errMsg The optional error message to be filled in case of any target | ||
| //! not being able to be added/removed. | ||
| //! \return True, if one ore more of the targets given are allowed to be | ||
| //! added/removed to the relationship in the stage's local Layer Stack. |
There was a problem hiding this comment.
Not sure if we should require that all desired changes be allowed? Was that specified in the story that we allow if a single one is correct and all the other incorrect?
| result = UsdUfe::isRelationshipEditAllowed( | ||
| relationship, &targetsToAddVec, &targetsToRemoveVec, &errMsg); | ||
|
|
||
| // pass the removal of elements to the python lists |
There was a problem hiding this comment.
Would it not be much simpler to copy the vector in full instead of these complicated iterations when the length changed? Popping multiple times will probably be less efficient anyway...
There was a problem hiding this comment.
I'm not sure if we can re-assign the list as the list object is a python object living in the calling context and getting passed from python into this function. In my humble and still tiny understanding of the python/c++ inter-op, I thought this needs to be adapted in place to have any affects on the outside scope, hence the popping.
Adding isRelationshipEditAllowed() to UsdUfe.
This function can be used to determine if a list of paths could be added to or removed from a collection within the current edit target.