Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FILE_SERVICE_URI that allows for full URI #6195

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Adirael
Copy link

@Adirael Adirael commented Mar 14, 2025

Description

Allows setting a full URI to interact with the VIP File System

Changelog Description

Changed

  • Renamed global variable that contains the VIP File System endpoint

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@Adirael Adirael requested a review from a team as a code owner March 14, 2025 10:04
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.44%. Comparing base (74d2acf) to head (480e22f).

Files with missing lines Patch % Lines
a8c-files.php 0.00% 2 Missing ⚠️
files/class-api-client.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6195      +/-   ##
=============================================
+ Coverage      30.42%   30.44%   +0.01%     
  Complexity      4826     4826              
=============================================
  Files            290      290              
  Lines          21329    21317      -12     
=============================================
  Hits            6489     6489              
+ Misses         14840    14828      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants