Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic Settings Policies for Azure App Service & Function App #133

Merged
merged 4 commits into from
Jan 12, 2022
Merged

Diagnostic Settings Policies for Azure App Service & Function App #133

merged 4 commits into from
Jan 12, 2022

Conversation

SenthuranSivananthan
Copy link
Contributor

@SenthuranSivananthan SenthuranSivananthan commented Jan 11, 2022 •
edited
Loading

Overview/Summary

  • Azure Policy definitions to enable diagnostic settings for logs through automation. There are two policy definitions added in this PR:

    • Policy for App Service
    • Policy for Function App

  • Update existing audit diagnostic settings policy to monitor for Microsoft.Web/sites resource type.

This PR fixes/adds/changes/removes

Fixes #132

Breaking Changes

None

Testing Evidence

  1. Create Azure Policy definitions for App Service & Function App

image

  1. Update Log Analytics custom initiative to include 2 new policies

image

  1. Verify that policy validates resources that are missing diagnostic settings

image

image

image

  1. Verify that policy remediates missing diagnostic settings

image

image

image

image

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@SenthuranSivananthan SenthuranSivananthan marked this pull request as ready for review January 11, 2022 21:56
hudua
hudua approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@hudua hudua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@hudua hudua merged commit 152c46c into Azure:main Jan 12, 2022
@hudua
Copy link
Contributor

hudua commented Jan 12, 2022

Looks good - thanks for the addition Senthuran!

@SenthuranSivananthan SenthuranSivananthan deleted the diagPolicy branch January 12, 2022 16:57
@SenthuranSivananthan SenthuranSivananthan mentioned this pull request Jan 12, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudua hudua hudua approved these changes

@skeeler skeeler Awaiting requested review from skeeler skeeler is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Diagnostic Settings at scale for Azure Web App & Functions
2 participants
@SenthuranSivananthan @hudua