Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeploySubscriptionIds parameter type casting #282

Merged
merged 32 commits into from
May 10, 2022
Merged

Fix DeploySubscriptionIds parameter type casting #282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6824cb3
Update CODEOWNERS
skeeler May 9, 2022
0062d67
add test config from stash
skeeler May 9, 2022
0558bfc
main implementation
skeeler May 9, 2022
606b68c
fix quoting issue
skeeler May 9, 2022
8b00238
reverse conditional
skeeler May 9, 2022
94a6159
revert CODEOWNERS so changes don't get back into upstream
skeeler May 9, 2022
c9dcb6f
fix subscription ids quoting
skeeler May 9, 2022
df419f2
Merge branch 'Azure:main' into skeeler
skeeler May 9, 2022
c4a71e2
Delete logging.parameters.json
skeeler May 9, 2022
dc48245
Delete azure-firewall-policy.parameters.json
skeeler May 9, 2022
a5a542a
Delete hub-network.parameters.json
skeeler May 9, 2022
f66a16c
Delete aef2d8e7-284e-4855-942b-6afc0469d1d5_generic-subscription_cana…
skeeler May 9, 2022
eb72fb0
Delete b30af792-1ec0-4a75-be1d-9aa4163ac626_generic-subscription_cana…
skeeler May 9, 2022
c8b2e7a
Delete CanadaPubSecALZ-skeeler-actions.yml
skeeler May 9, 2022
c450119
Delete hub-network.parameters.json
skeeler May 9, 2022
f8e7578
Merge remote-tracking branch 'azure/main' into skeeler
skeeler May 9, 2022
b1bedda
test configuration
skeeler May 9, 2022
247834e
test param passing
skeeler May 9, 2022
f64308d
test params
skeeler May 9, 2022
110a0f8
fix name
skeeler May 9, 2022
7c23d97
fix
skeeler May 9, 2022
bf5ecb1
testing
skeeler May 9, 2022
e91152a
fix DeploySubscriptionIds parameter eval
skeeler May 10, 2022
cf244c2
fix environment name quoting
skeeler May 10, 2022
3625a30
Merge branch 'Azure:main' into skeeler
skeeler May 10, 2022
2969e7f
Delete CanadaPubSecALZ-skeeler-actions.yml
skeeler May 10, 2022
f79db7b
Delete b30af792-1ec0-4a75-be1d-9aa4163ac626_generic-subscription_cana…
skeeler May 10, 2022
329bcdb
Delete aef2d8e7-284e-4855-942b-6afc0469d1d5_generic-subscription_cana…
skeeler May 10, 2022
087efea
Delete hub-network.parameters.json
skeeler May 10, 2022
a936347
Delete logging.parameters.json
skeeler May 10, 2022
2b98854
Delete azure-firewall-policy.parameters.json
skeeler May 10, 2022
60f227d
Delete hub-network.parameters.json
skeeler May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/0-everything.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,10 @@ jobs:
-NvaPassword (ConvertTo-SecureString -String '${{secrets.NVA_PASSWORD}} '-AsPlainText -Force)

- name: Deploy Subscriptions
if: github.event.inputs.subscriptionIds != ''
if: github.event.inputs.subscriptionIds != null
run: |
./RunWorkflows.ps1 `
-DeploySubscriptionIds '${{github.event.inputs.subscriptionIds}}' `
-DeploySubscriptionIds @( ${{github.event.inputs.subscriptionIds}} ) `
-EnvironmentName '${{github.event.inputs.environmentName}}' `
-LoginServicePrincipalJson (ConvertTo-SecureString -String '${{secrets.ALZ_CREDENTIALS}}' -AsPlainText -Force) `
-GitHubRepo ${env:GITHUB_REPOSITORY} `
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/6-subscriptions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ jobs:
Install-Module powershell-yaml -Force

- name: Deploy Subscriptions
if: github.event.inputs.subscriptionIds != null
run: |
./RunWorkflows.ps1 `
-DeploySubscriptionIds '${{github.event.inputs.subscriptionIds}}' `
-DeploySubscriptionIds @( ${{github.event.inputs.subscriptionIds}} ) `
-EnvironmentName '${{github.event.inputs.environmentName}}' `
-LoginServicePrincipalJson (ConvertTo-SecureString -String '${{secrets.ALZ_CREDENTIALS}}' -AsPlainText -Force) `
-GitHubRepo ${env:GITHUB_REPOSITORY} `
Expand Down
2 changes: 1 addition & 1 deletion scripts/deployments/RunWorkflows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ OF MERCHANTABILITY AND/OR FITNESS FOR A PARTICULAR PURPOSE.
If true, run the NVA hub network workflow.

.PARAMETER DeploySubscriptionIds
Comma separated list of subscription ids to run the subscription workflow against.
Comma separated list of quoted subscription ids to run the subscription workflow against.

.PARAMETER EnvironmentName
The name of the environment to run the workflow against.
Expand Down