fix(designer): Improve types in updateDynamicDataInNode to prevent issues
#5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement Checklist
Type of Change
Current behavior
Prior to #5207, there was a bug where an
undefinedparameter could be passed despite the invoked method not acceptingundefined, due to a use ofany. This was fixed in #5207 by adding an!isNullOrUndefinedcheck, but the typing was not updated to force this constraint, meaning that the removal of that conditional still compiles:New Behavior
Types have been updated to force the requirement that no item is
undefined:Impact of Change
No breaking changes.