fix(designer): Sets right run data from repetition for nested components instead of general run data #5347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Code Changes
Waiting
status pill from a static svg to spinner component to add more sense of loadingThis pull request includes several changes aimed at improving code maintainability, enhancing functionality, and updating UI elements. The most important changes are grouped by theme below.
Removed the
onRunInstanceSuccess
callback from theuseRunInstanceStandard
hook and moved its logic to auseEffect
hook inlaDesigner.tsx
to simplify the code structure.Removed unused import
LogicAppsV2
fromlaDesigner.tsx
andOperationCardNode.tsx
to clean up the code.Replaced the SVG loading spinner with the Fluent UI
Spinner
component for better consistency and accessibility.Added logic to handle run repetition data within a
useEffect
hook, ensuring that the data is dispatched correctly when available.Fixes #5167
Both scenarios are set in slooow (10 mbs) download network to be more explicit, but this also happens when workflows are too big and repetition API calls are made after all actions are loaded
Before
Screen.Recording.2024-08-09.at.11.46.56.AM.mov
After
Screen.Recording.2024-08-09.at.11.54.48.AM.mov