Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Sets right run data from repetition for nested components instead of general run data #5347

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Aug 9, 2024

Main Code Changes

  • Fixes issues in which run data for nested components wasn't set properly. The data was getting set from the general run data instead of the specific repetition of the parent component. Therefore was showing wrong data.
  • New behavior shows the spinner component for nested components and waits for api call from repetition to show it right run data
  • Updates Waiting status pill from a static svg to spinner component to add more sense of loading

This pull request includes several changes aimed at improving code maintainability, enhancing functionality, and updating UI elements. The most important changes are grouped by theme below.

  • Removed the onRunInstanceSuccess callback from the useRunInstanceStandard hook and moved its logic to a useEffect hook in laDesigner.tsx to simplify the code structure.

  • Removed unused import LogicAppsV2 from laDesigner.tsx and OperationCardNode.tsx to clean up the code.

  • Replaced the SVG loading spinner with the Fluent UI Spinner component for better consistency and accessibility.

  • Added logic to handle run repetition data within a useEffect hook, ensuring that the data is dispatched correctly when available.

Fixes #5167

Both scenarios are set in slooow (10 mbs) download network to be more explicit, but this also happens when workflows are too big and repetition API calls are made after all actions are loaded

Before

Screen.Recording.2024-08-09.at.11.46.56.AM.mov

After

Screen.Recording.2024-08-09.at.11.54.48.AM.mov

@ccastrotrejo ccastrotrejo changed the title Ccastrotrejo/loading monitoring fix(designer): Sets right run data from repetition for nested components instead of general run data Aug 9, 2024
@ccastrotrejo ccastrotrejo marked this pull request as ready for review August 9, 2024 23:27
@hartra344 hartra344 merged commit 76a7400 into main Aug 10, 2024
13 checks passed
@ccastrotrejo ccastrotrejo deleted the ccastrotrejo/loadingMonitoring branch August 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new logic app workflow run is showing wrong execution time on actions
2 participants