Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(designer): Fixed various bugs in undo/redo #5899

Merged
merged 13 commits into from
Oct 17, 2024

Conversation

shuktika12163
Copy link
Contributor

@shuktika12163 shuktika12163 commented Oct 17, 2024

Requirement Checklist

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes or features)
  • Docs have been added or updated (for bug fixes or features)

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

List of bugs being tackled here (in review/active) - each commit is associated with each fix:
https://msazure.visualstudio.com/One/_queries/query/a6e3b020-844f-409b-9bf5-5f5163419d4a/

  1. Parameter panel re-render edge case: Bug 29820667: [V3 undo redo bug bash] Undoing a change in the panel without reopening the panel does not reflect the state update

  2. Delete operations:

  • Bug 29821282: [V3 undo redo bug bash] Deleting a scope adds an "invisible" undo step (i.e., you can undo one additional time after undoing deleting the scope)
  • Bug 29821013: [V3 undo redo bug bash] Removing condition or scope undo-es each remove individually
  1. Optional parameter conditional visibility: Bug 29857755: [V3 undo redo bug bash] Removing optional parameter is skipping a state in between

  2. Manual trigger/floating action menu:

  • Bug 29821430: [V3 undo redo bug bash] Manual trigger text input undoes 1 keystroke at a time
  • Bug 29851270: [V3 undo redo bug bash] Floating action menu outputs editor does not save state
  • Bug 29900468: [V3 undo redo bug bash] Manual trigger undo doesn't work
  1. Title update issues
  • Custom people picker editor causing re-render in parameters panel causing title updates without any changes: Bug 29820626: [V3 undo redo bug bash] Undo/redo doesn't work when there are changes in people picker editor
  • Clicking in and out of title was saving a state even without any changes

New Behavior

Above bugs have been fixed:

  1. Parameter re-render fix:
    parameterRerender

  2. Delete operations fix:
    deleteOperations

  3. Optional parameter conditional visibility fix:
    optionalParameter

  4. Manual trigger/floating action menu fixes:
    floatingActionMenu

  5. People picker/title change fix:
    Clicking in and out of title doesn't save a new state. It only saves state when value changes
    titleFix

Impact of Change

  • This is a breaking change.

Screenshots or Videos (if applicable)

@rllyy97 rllyy97 enabled auto-merge (squash) October 17, 2024 21:41
@rllyy97 rllyy97 merged commit 16d4c9b into Azure:main Oct 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants