Feat(Data Mapper): Panel with warning and error messages #6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielleCogs
changed the title
|
Nice! This is a great start. Can we change the toggle to be just a button instead? Maybe a Red color Error/Warnings text and also to the left of the code view toggle? |
I can change the toggle, but I think Kristin is working on designs for this so I'd prefer to wait until she reviews this to tweak colors |
takyyon
approved these changes
Jan 2, 2025
takyyon
pushed a commit
that referenced
this pull request
Jan 24, 2025
* started moving to v9 component * api call works * added value * started test * simplifying * update to fix fluent ui bug * component test passes * fixed type error * update version of fluent 9 * updated snapshots * updated lockfile * starting docs * moved over v1 map checker * simple panel works * new error store * added docs and displayed deserialization messages * panels close when others open * added required input checeker * PR prep * PR Comments * updated yaml for tests
takyyon
added a commit
that referenced
this pull request
Jan 27, 2025
…lic preview (#6470) * Feat(Data Mapper): Panel with warning and error messages (#6315) * started moving to v9 component * api call works * added value * started test * simplifying * update to fix fluent ui bug * component test passes * fixed type error * update version of fluent 9 * updated snapshots * updated lockfile * starting docs * moved over v1 map checker * simple panel works * new error store * added docs and displayed deserialization messages * panels close when others open * added required input checeker * PR prep * PR Comments * updated yaml for tests * feat(Data Mapper): Add keyboard delete, fix circles cutting, handle existing map loading (#6329) * add keyboard delete * only use delete when funciton or edge is selected * remove backspace * update width to handle circles cutting * fix auto layouting * Feat(Data Mapper): UX fixes for Public Preview (#6363) * added new map placeholder * added some colors * custom info label * PR prep * Fix(Data Mapper): Sequence function serialization bug (#6378) * fixed serialization issue * test fix * fix(Data Mapper): Fix circles cutting off (#6379) data mapper update * Fix(Data Mapper): bracket serialization bug (#6385) * fixed bracket bug * fixed typo in test * feat(Data Mapper): Add notification to vscode from DM (#6390) * setup vscode notification * update toast to vscode * fix(Data Mapper): Update Function config panel to fix wrapping, delete logic, placement of action items, info bubble (#6393) * dm font * fix func config panel * update function config 2 * fix style cherry-pick * add remove logic * fix margin * feat(Data Mapper): Add info message and fix placeholders (#6405) info message * Fix(Data Mapper): add new files (#6396) * starting using vscode file api * fixing file fn * file copy works and with schema imports * error message works * added info label * fix(Data Mapper): Update height/width of panel and enhance Error/Warning panel (#6410) * fix height * enhance test panel * fix(Data Mapper): Update string and open all functions by default (#6413) open by default * update strings * merge main * merge * merge string changes * update string * Feat(Data Mapper): Loop message when users try to find loop in functions (#6451) message works * fix(Data Mapper): Fix unnecessary edge when node/parent is not in the search results (#6454) * fix(Data Mapper): Pass in loading as a normal prop since boolean behaves differently (#6456) loading passed * fix(Data Mapper): Remove extra styling and clear out test results (#6459) * update node position on search term change * clear out test panel * update circles * fix(Data Mapper): Add subtitle for error/warning cards (#6464) * node udpates * add subtitle --------- Co-authored-by: DanielleCogs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement Checklist
Type of Change
Current Behavior
no error messages or warnings about map
New Behavior
New panel to display messages
Impact of Change
Screenshots or Videos (if applicable)
Screen.Recording.2024-12-29.at.2.52.10.PM.mov