feat(Templates): Restructure to Reflect Custom Templates Restructuring #6730

Elaina-Lee · 2025-03-05T01:45:29Z

Type of Change

Bug fix
Feature
Other

No feature updates (No change in UI)
Restructuring templates to align with manifest separation of TemplateManifest and WorkflowManifest
Introduction: id for both manifests, description => summary, detailsDescription => description
Mock data updates for LocalTemplates

Impact of Change

Restructuring: Separating Template.Manifest into Template.TemplateManifest and Template.WorkflowManifest

Disregarding of whether a wrkflow or accelerator template, it will follow the same way of containing manifests

This is a breaking change.

Test Plan

All previous tests using Template.Manifest has been updated and have been verified to do the same with new way of redux stores updates containing separate manifests

Screenshots or Videos (if applicable)

downloadTemplates.js

libs/logic-apps-shared/src/utils/src/lib/models/template.ts

libs/logic-apps-shared/src/designer-client-services/lib/base/template.ts

libs/designer/src/lib/ui/templates/templateoverview.tsx

libs/logic-apps-shared/src/designer-client-services/lib/template.ts

libs/designer/src/lib/ui/templates/templateoverview.tsx

libs/designer/src/lib/ui/templates/__tests__/templateCard.spec.tsx

libs/designer/src/lib/ui/templates/__tests__/displayConnections.spec.tsx

libs/designer/src/lib/ui/panel/templatePanel/quickViewPanel/tabs/summaryTab.tsx

libs/designer/src/lib/core/actions/bjsworkflow/templates.ts

libs/designer/src/lib/core/templates/utils/helper.ts

libs/logic-apps-shared/src/utils/src/lib/models/template.ts

Co-authored-by: Priti Sambandam <[email protected]>

…ation

Elaina-Lee added 12 commits March 4, 2025 11:58

added TemplateManifest and WorkflowManifest

fdf294e

first batch of restructure

612161c

updated the script

de8d204

fixed logic for checking multi workflow

77d7006

improvements

be3a107

fixed operation id not being picked up for builtin problem

d845caf

fixed built in info not kicking in

cbf5d35

removed builtin operation logic

b664f3a

fixed mock data

4a20172

removed unused function

25c9a7d

fixed createWorkflowPanel test

77c3373

fixed template panel tests

22d528c

Elaina-Lee added the Risk:Medium label Mar 6, 2025

fixed template tests

60acdfa

Elaina-Lee marked this pull request as ready for review March 6, 2025 01:04

Elaina-Lee requested a review from hartra344 as a code owner March 6, 2025 01:04

preetriti1 reviewed Mar 6, 2025

View reviewed changes

downloadTemplates.js Outdated Show resolved Hide resolved

preetriti1 reviewed Mar 6, 2025

View reviewed changes

libs/logic-apps-shared/src/utils/src/lib/models/template.ts Outdated Show resolved Hide resolved

preetriti1 reviewed Mar 6, 2025

View reviewed changes

libs/logic-apps-shared/src/designer-client-services/lib/base/template.ts Outdated Show resolved Hide resolved

preetriti1 reviewed Mar 6, 2025

View reviewed changes

libs/designer/src/lib/ui/templates/templateoverview.tsx Outdated Show resolved Hide resolved

Elaina-Lee added 3 commits March 6, 2025 11:22

removed download image

2612012

combined get manifest calls to one

39e51b8

fixed filter undefined isuse

e98a4da

preetriti1 requested changes Mar 6, 2025

View reviewed changes

Elaina-Lee added 3 commits March 6, 2025 15:39

reflected comments

d144153

removed custom connection & brought back empty trigger row

1fb18b4

fixed overwriting for viewTemplate

ff8cdcd

preetriti1 reviewed Mar 7, 2025

View reviewed changes

libs/designer/src/lib/core/templates/utils/helper.ts Show resolved Hide resolved

preetriti1 reviewed Mar 7, 2025

View reviewed changes

libs/logic-apps-shared/src/utils/src/lib/models/template.ts Outdated Show resolved Hide resolved

removed builtin from connectorRuntimeType

6c022cf

preetriti1 approved these changes Mar 7, 2025

View reviewed changes

fixed Connection to FeaturedConnector for displaying connector

a4645cc

Elaina-Lee enabled auto-merge (squash) March 8, 2025 00:49

Elaina-Lee and others added 4 commits March 7, 2025 17:05

fixed viewTemplate test

3579960

Fixing failing test case (#6745)

c1d36d8

Co-authored-by: Priti Sambandam <[email protected]>

Merge branch 'main' into elaina/restructureTemplates

ecdbf29

Cloning the manifest data before storing it in store to allow modific…

b11b9c5

…ation

Elaina-Lee merged commit 971bdb4 into main Mar 8, 2025
13 checks passed

Elaina-Lee deleted the elaina/restructureTemplates branch March 8, 2025 05:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(Templates): Restructure to Reflect Custom Templates Restructuring #6730

feat(Templates): Restructure to Reflect Custom Templates Restructuring #6730

Elaina-Lee commented Mar 5, 2025 •

edited

Loading

feat(Templates): Restructure to Reflect Custom Templates Restructuring #6730

feat(Templates): Restructure to Reflect Custom Templates Restructuring #6730

Conversation

Elaina-Lee commented Mar 5, 2025 • edited Loading

Type of Change

Impact of Change

Test Plan

Screenshots or Videos (if applicable)

Elaina-Lee commented Mar 5, 2025 •

edited

Loading