Make rpc.go so it can use a single link and send/receive multiple messages #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 24, 2021 22:18
… the channel if they cancel the wait.
serbrech
reviewed
Aug 26, 2021
jhendrixMSFT
approved these changes
Aug 26, 2021
There was a problem hiding this comment.
Tentative approval as I'm out and don't want to block on this getting in.
Once you and @serbrech are happy with it and confident it works please merge and tag.
added 5 commits
August 26, 2021 14:28
- Do a type check when casting for CorrelationID. For now, just ignore those uncastable messages.
…it anymore after that).
serbrech
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service Bus and Event Hubs both allow you to send multiple messages on the management link. We weren't using this and it meant that we were creating a separate link per request.
This PR changes that so we pass in a unique message ID for each request, which allows us to demux the requests in the client, thus only using a single link.
This is how the other track 2 SDKs currently handle it.