Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimum log buffer size calculation #2372

Merged
merged 15 commits into from
Oct 28, 2022
Merged

Fix minimum log buffer size calculation #2372

merged 15 commits into from
Oct 28, 2022

Conversation

antkmsft
Copy link
Member

@antkmsft antkmsft commented Oct 27, 2022 •
edited
Loading

Closes #2224

@antkmsft antkmsft self-assigned this Oct 27, 2022
@antkmsft antkmsft added this to the 2022-11 milestone Oct 27, 2022
@antkmsft antkmsft marked this pull request as ready for review October 27, 2022 18:00
ahsonkhan
ahsonkhan approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@ahsonkhan ahsonkhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CL entry?

Regarding testing, this could benefit from a unit test.

@antkmsft antkmsft merged commit 94b5847 into Azure:main Oct 28, 2022
@antkmsft antkmsft deleted the logging-fix branch October 9, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsonkhan ahsonkhan ahsonkhan approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@gearama gearama Awaiting requested review from gearama gearama is a code owner

Assignees

@antkmsft antkmsft

Labels
Azure.Core
Projects
None yet
Milestone
2022-11
Development

Successfully merging this pull request may close these issues.

Incorrect Calculation _az_http_policy_logging_append_http_request_msg()
2 participants
@antkmsft @ahsonkhan