Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Redis passwordless connections for Azure Redis Cache in Spring #32794

Merged
merged 39 commits into from
Jan 19, 2023
Merged

Support Redis passwordless connections for Azure Redis Cache in Spring #32794

merged 39 commits into from
Jan 19, 2023

Conversation

backwind1233
Copy link
Contributor

@backwind1233 backwind1233 commented Jan 6, 2023 •
edited
Loading

Description

Linked issue: #31350

The PR is an implementation to support passwordless connections for Azure Redis Cache in Spring.

Supported Scopes

  1. It only support Jedis and it requires jedis client version 3.8.x, not compatible with jedis 4.x.
  2. It requires spring boot 2.6.x or 2.7.x.
  3. It supports pooled and non-pooled configuration.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Azure.Identity azure-spring All azure-spring related issues labels Jan 6, 2023
@backwind1233 backwind1233 self-assigned this Jan 6, 2023
@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jan 6, 2023 •
edited
Loading

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure
spring-cloud-azure-starter-redis

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@backwind1233
Copy link
Contributor Author

/azp run java - spring

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@backwind1233
Copy link
Contributor Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna requested changes Jan 13, 2023
View reviewed changes
...cloud/autoconfigure/implementation/redis/passwordless/jedis/AzureJedisConnectionFactory.java Outdated
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

package com.azure.spring.cloud.autoconfigure.implementation.redis.passwordless.jedis;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for this one.

saragluna
saragluna requested changes Jan 17, 2023
View reviewed changes
@backwind1233 backwind1233 mentioned this pull request Jan 17, 2023
Closed
2 tasks
@backwind1233
Copy link
Contributor Author

@saragluna more comments?

@backwind1233 backwind1233 merged commit f4ce1c0 into Azure:main Jan 19, 2023
@backwind1233 backwind1233 mentioned this pull request Jan 19, 2023
Closed
6 tasks
This was referenced Jan 31, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@hallipr hallipr Awaiting requested review from hallipr hallipr is a code owner

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio JimSuplizio is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@fangjian0423 fangjian0423 Awaiting requested review from fangjian0423

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@benbp benbp Awaiting requested review from benbp benbp is a code owner

Assignees

@backwind1233 backwind1233

Labels
Azure.Identity azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
2023-02
Development

Successfully merging this pull request may close these issues.
4 participants
@backwind1233 @azure-sdk @saragluna @Netyyyy