Skip to content

Commit

Permalink
fix: Update avm/res/net-app/net-app-account - fix optional zone for…
Browse files Browse the repository at this point in the history
… volumes and specify `protocolTypes` options (#4469)

## Description
This PR resolves the following issues in the
`avm/res/net-app/net-app-account` module
* On the NetApp Volume submodule, `zone` has been renamed to
`availabilityZone`.
* The type for `availabilityZone` has been changed to `string` from
`int[]` and is now optional with null as the default. Previously the
module would try and deploy a volume into all three zones if no value is
defined.
* Changed: `protocolTypes` is now an optional array of strings with
three possible options `'NFSv3', 'NFSv4.1', and 'CIFS'`. If no value is
provided, the default value of `['NFSv3']` is used.
* Added to the description for `protocolTypes` indicating that the user
will need to specify `['NFSv3','CIFS']` or `['NFSv4.1','CIFS']` if
creating dual-stack volumes.
* Added in additional submodule README.md and main.json files generated
by Set-AVMModule.

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #4506
Closes #4534

-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.net-app.net-app-account](https://github.com/thecmdradama/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml/badge.svg?branch=fix%2Fnetapp-pattern)](https://github.com/thecmdradama/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Adam Ricket <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
  • Loading branch information
3 people authored Feb 26, 2025
1 parent 7732c3f commit 13555e6
Show file tree
Hide file tree
Showing 16 changed files with 639 additions and 223 deletions.
260 changes: 200 additions & 60 deletions avm/res/net-app/net-app-account/README.md

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions avm/res/net-app/net-app-account/backup-policies/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.33.13.18514",
"templateHash": "7141176618644423280"
"version": "0.33.93.31351",
"templateHash": "2748634922557584170"
},
"name": "Azure NetApp Files Backup Policy",
"description": "This module deploys a Backup Policy for Azure NetApp File."
Expand Down
4 changes: 2 additions & 2 deletions avm/res/net-app/net-app-account/backup-vault/backup/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.33.13.18514",
"templateHash": "3948084235912412629"
"version": "0.33.93.31351",
"templateHash": "17452697444375969559"
},
"name": "Azure NetApp Files Volume Backup",
"description": "This module deploys a backup of a NetApp Files Volume."
Expand Down
8 changes: 4 additions & 4 deletions avm/res/net-app/net-app-account/backup-vault/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.33.13.18514",
"templateHash": "9738469557677047438"
"version": "0.33.93.31351",
"templateHash": "6704781490326075849"
},
"name": "Azure NetApp Files Volume Backup Vault",
"description": "This module deploys a NetApp Files Backup Vault."
Expand Down Expand Up @@ -144,8 +144,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.33.13.18514",
"templateHash": "3948084235912412629"
"version": "0.33.93.31351",
"templateHash": "17452697444375969559"
},
"name": "Azure NetApp Files Volume Backup",
"description": "This module deploys a backup of a NetApp Files Volume."
Expand Down
Loading

0 comments on commit 13555e6

Please sign in to comment.