Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update API versions + Fix readme and ARM templates that weren't regenerated in a previous PR #4685

Merged
merged 2 commits into from
Mar 5, 2025

Conversation

bryansan-msft
Copy link
Contributor

@bryansan-msft bryansan-msft commented Mar 5, 2025

Description

  • Updated API versions for all resources to the last supported version that is not in preview. There are no new supported properties though.
  • Regenerate avm files since it was not done in a previous PR

Closes #4391
Fixes #4683

Pipeline Reference

Pipeline
avm.res.document-db.database-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@bryansan-msft bryansan-msft self-assigned this Mar 5, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Mar 5, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Mar 5, 2025

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@bryansan-msft bryansan-msft changed the title Update API versions + Fix readme and ARM templates that weren't regenerated in a previous PR fix: Update API versions + Fix readme and ARM templates that weren't regenerated in a previous PR Mar 5, 2025
@bryansan-msft bryansan-msft marked this pull request as ready for review March 5, 2025 11:30
@bryansan-msft bryansan-msft requested review from a team as code owners March 5, 2025 11:30
@bryansan-msft bryansan-msft enabled auto-merge (squash) March 5, 2025 11:30
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Mar 5, 2025
@bryansan-msft
Copy link
Contributor Author

@Azure/avm-module-reviewers-bicep and @seesharprun If you have spare time, I would appreciate a review since @mayablumovitz needs it a bit urgently

Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@bryansan-msft bryansan-msft merged commit 021667a into Azure:main Mar 5, 2025
23 of 24 checks passed
@bryansan-msft bryansan-msft deleted the feature/update_api_versions branch March 5, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Resource API version outdated and missing parameters
2 participants