rc2: vendor github.com/dgryski/go-rc2 #24
Conversation
| https://www.ietf.org/rfc/rfc2268.txt | ||
| http://people.csail.mit.edu/rivest/pubs/KRRR98.pdf | ||
|
|
||
| This code is licensed under the MIT license. |
There was a problem hiding this comment.
This license header may need to change or be removed?
Even though Microsoft is using a MIT license too: https://github.com/Azure/go-pkcs12/blob/master/LICENSE
This will all need to change when submitted to x/crypto: http://golang.org/doc/contribute.html#copyright
There was a problem hiding this comment.
The rest of go-pkcs12 is also under MIT. I can of course relicense it under the Go license when that change occurs.
|
Thanks @dgryski. I'm a crypto novice, so I'm commenting on surface level code style things. I'll let the fine folks at Microsoft do a proper review. |
|
One last thing, I think all exported identifiers should have comments (golint). Comments on internal identifiers doesn't hurt either. |
This eliminates an external dependency and simplifies the addition of go-pkcs12 to /x/crypto.
|
The cipher is functioning fine on the pkcs12 test cases and we'll get the real crypto review when we try to contribute it to x/crypto, where the experts are. |
|
All exported identifiers have godoc. |
|
Today I received my Microsoft CLA approval. |
|
Awesome, thanks @dgryski |
rc2: vendor github.com/dgryski/go-rc2
This eliminates an external dependency and simplifies the addition of
go-pkcs12 to /x/crypto.